Re: [Xen-devel] [PATCH] pub-headers: reduce C99 dependencies

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Sep 28, 2016 at 08:14:51AM -0600, Jan Beulich wrote:
> >>> On 28.09.16 at 16:04, <wei.liu2@xxxxxxxxxx> wrote:
> > On Wed, Sep 28, 2016 at 06:00:31AM -0600, Jan Beulich wrote:
> >> For consumers not using (fully) C99-aware compilers, limit the number
> >> of places where tweaking of the headers would be necessary: Introduce
> >> and use xen_mk_ullong(), allowing its helper macro to be overridden at
> >> once.
> >> 
> >> For now don't touch public/io/, which also has a few offenders.
> >> 
> >> The need to include xen.h in hvm/e820.h demonstrates that it is a bad
> >> idea to include public headers first thing - arch/x86/hvm/mtrr.c needs
> >> adjustment just because of this.
> >> 
> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> >> ---
> >> I wonder why all those ARM constants carry the ULL suffix despite only
> >> two of them actually exceeding 32 significant bits.
> >> 
> >> --- a/xen/arch/x86/hvm/mtrr.c
> >> +++ b/xen/arch/x86/hvm/mtrr.c
> >> @@ -16,7 +16,6 @@
> >>   * this program; If not, see <http://www.gnu.org/licenses/>.
> >>   */
> >>  
> >> -#include <public/hvm/e820.h>
> >>  #include <xen/domain_page.h>
> >>  #include <asm/e820.h>
> >>  #include <asm/iocap.h>
> >> @@ -25,6 +24,7 @@
> >>  #include <asm/mtrr.h>
> >>  #include <asm/hvm/support.h>
> >>  #include <asm/hvm/cacheattr.h>
> >> +#include <public/hvm/e820.h>
> >>  
> > 
> > Unrelated change here.
> 
> Definitely not - see the commit message.
> 

Ah, sorry about the noise.

> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel