Re: [Xen-devel] [PATCH v2 6/9] tmem/libxc: Squash XEN_SYSCTL_TMEM_OP_[SET|SAVE]..

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Sep 30, 2016 at 02:11:51PM -0400, Konrad Rzeszutek Wilk wrote:
> ---
>  tools/libxc/xc_tmem.c             |  73 +++++++++++----------------
>  tools/libxl/libxl.c               |  26 +++++++---
>  tools/python/xen/lowlevel/xc/xc.c |   2 -

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

>  xen/common/tmem.c                 |   2 +
>  xen/common/tmem_control.c         | 102 
> ++++++++++++++++++++++----------------
>  xen/include/public/sysctl.h       |  23 ++++++---
>  xen/include/xen/tmem_xen.h        |   2 +-
>  7 files changed, 126 insertions(+), 104 deletions(-)
> 
> diff --git a/tools/libxc/xc_tmem.c b/tools/libxc/xc_tmem.c
> index e1de16e..7c06841 100644
> --- a/tools/libxc/xc_tmem.c
> +++ b/tools/libxc/xc_tmem.c
> @@ -18,6 +18,7 @@
>   */
>  
>  #include "xc_private.h"
> +#include <assert.h>
>  #include <xen/tmem.h>
>  
>  static int do_tmem_op(xc_interface *xch, tmem_op_t *op)
> @@ -67,7 +68,12 @@ int xc_tmem_control(xc_interface *xch,
>      sysctl.u.tmem_op.oid.oid[1] = 0;
>      sysctl.u.tmem_op.oid.oid[2] = 0;
>  
> -    if ( cmd == XEN_SYSCTL_TMEM_OP_LIST && arg1 != 0 )
> +    if ( cmd == XEN_SYSCTL_TMEM_OP_SET_CLIENT_INFO )
> +    {
> +        HYPERCALL_BOUNCE_SET_DIR(buf, XC_HYPERCALL_BUFFER_BOUNCE_IN);
> +    }

"Braces should be omitted for blocks with a single statement."

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel