Re: [Xen-devel] [PATCH v2 5/9] gcov: add new interface and 3.4 and 4.7 format support

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.10.16 at 14:23, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 10/10/16 12:56, Jan Beulich wrote:
>>>>> On 10.10.16 at 11:40, <wei.liu2@xxxxxxxxxx> wrote:
>>> +struct type_info {
>>> +    int ctr_type;
>> Can this be negative?
> 
> This code is largely imported straight from Linux.  We should not
> needlessly deviate.

Hmm, in that case some of the constification I did ask for on v1 and
which is now there should also be undone? Perhaps for such a
purpose it would help if the original Linux files got first imported
verbatim (without any review comments, and without getting wired
up), in order to then be modified minimally to build/work on Xen?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel