Re: [Xen-devel] [PATCH v2 8/9] Config.mk: introduce cc-ifversion

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.10.16 at 15:18, <wei.liu2@xxxxxxxxxx> wrote:
> On Mon, Oct 10, 2016 at 06:00:03AM -0600, Jan Beulich wrote:
>> >>> On 10.10.16 at 11:40, <wei.liu2@xxxxxxxxxx> wrote:
>> > It returns different string depending on compiler version.
>> > 
>> > No user yet.
>> > 
>> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
>> 
>> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>> albeit I wonder whether ...
>> 
>> > --- a/Config.mk
>> > +++ b/Config.mk
>> > @@ -128,6 +128,11 @@ define cc-ver-check-closure
>> >      endif
>> >  endef
>> >  
>> > +# cc-ifversion: Check compiler version and take branch accordingly
>> > +# Usage $(call cc-ifversion,lt,0x040700,string_if_y,string_if_n)
>> > +cc-ifversion = $(shell [ $(call cc-ver,$(CC),$(1),$(2)) = "y" ] \
>> > +                          && echo $(3) || echo $(4))
>> 
>> ... if-cc-version wouldn't be the better name.
> 
> Linux uses cc-ifversion. That's the naming scheme I followed.

Oh, I didn't realize you've taken it from elsewhere.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel