Re: [Xen-devel] [PATCH v2 25/30] xen/x86: add all PCI devices to PVHv2 Dom0

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.09.16 at 17:57, <roger.pau@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/domain_build.c
> +++ b/xen/arch/x86/domain_build.c
> @@ -2378,6 +2378,25 @@ static int __init hvm_setup_acpi(struct domain *d)
>      return 0;
>  }
>  
> +static int __init hvm_setup_pci(struct domain *d)
> +{
> +    struct pci_dev *pdev;
> +    int rc;
> +
> +    printk("** Adding PCI devices **\n");
> +
> +    pcidevs_lock();
> +    list_for_each_entry( pdev, &d->arch.pdev_list, domain_list )
> +    {
> +        rc = hwdom_add_device(pdev);

Considering the loop construct it is clear that the devices must
already have been added to the domain by the time you get here.
Hence the title (together with there not being any description) is
at least misleading.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel