Re: [Xen-devel] [PATCH for-4.8] ipxe: update to newer commit

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Boris Ostrovsky writes ("Re: [Xen-devel] [PATCH for-4.8] ipxe: update to newer 
commit"):
> On 10/11/2016 05:52 AM, Ian Jackson wrote:
> > Maybe we could consider these as backports to earlier releases.
> > However, I looked at the patch and it mostly seems to be removing null
> > pointer checks.  I find this ... surprising.
> 
> That's because routines have __nonnull attribute (which tells compiler
> that arguments are never NULL) and new gcc warns on non-NULL checks for
> these arguments.

*sigh*  Why don't we just disable that warning ?

> Another interesting new warning that is fatal with -Werror is
>     if(a)
>         foo();
>         bar();
> 
> gcc warns that bar() is indented and maybe braces are needed.

Do we actually have cases like this ?  Are they real bugs ?

> BTW, another option for backporting may be removing -Werror. If we know
> we are not changing sources then we might consider this.

Perhaps we could disable warnings more selectively.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel