Re: [Xen-devel] [PATCH v5 6/7] VT-d: Some cleanups

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.10.16 at 02:57, <feng.wu@xxxxxxxxx> wrote:
> @@ -638,7 +638,8 @@ static int msi_msg_to_remap_entry(
>      GET_IREMAP_ENTRY(ir_ctrl->iremap_maddr, index,
>                       iremap_entries, iremap_entry);
>  
> -    memcpy(&new_ire, iremap_entry, sizeof(struct iremap_entry));
> +    if ( iremap_entry->remap.p )
> +        new_ire.remap.im = iremap_entry->remap.im;

This is certainly more of a change than what title and description
suggest. If you really mean it to be this way, it needs to be
explained in the description.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel