Re: [Xen-devel] [PATCH v2 0/2] Remove PAGE_SIZE from public headers

[Juergen Gross <jgross@xxxxxxxx>]

On 19/10/16 21:21, stefano@xxxxxxxxxxx wrote:
> Reference to PAGE_SIZE slipped in to two public header files. QEMU build on
> ARM64 is broken by this. PAGE_SIZE should not be used because it could
> be undefined or it could be defined differently on different operating
> systems.
> 
> Stefano Stabellini (2):
>       usbif.h: replace PAGE_SIZE with USBIF_RING_SIZE
>       vscsiif.h: replace PAGE_SIZE with VSCSIIF_PAGE_SIZE
> 
>  xen/include/public/io/usbif.h   | 5 +++--
>  xen/include/public/io/vscsiif.h | 3 ++-
>  2 files changed, 5 insertions(+), 3 deletions(-)
> 

In principle I'm okay with these changes. But wouldn't it be
better to add

#define XEN_RING_PAGE_SIZE 4096

to xen/include/public/io/ring.h instead of having each interface
file its own definition?


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel