Re: [Xen-devel] [PATCH v2 for-4.9 1/2] x86/emul: Use explicit __attribute__((packed)) rather than __packed

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 26/10/16 09:54, Jan Beulich wrote:
>>>> On 25.10.16 at 20:10, <andrew.cooper3@xxxxxxxxxx> wrote:
>> --- a/xen/arch/x86/x86_emulate/x86_emulate.h
>> +++ b/xen/arch/x86/x86_emulate/x86_emulate.h
>> @@ -71,7 +71,7 @@ enum x86_swint_emulation {
>>   * Attribute for segment selector. This is a copy of bit 40:47 & 52:55 of 
>> the
>>   * segment descriptor. It happens to match the format of an AMD SVM VMCB.
>>   */
>> -typedef union __packed segment_attributes {
>> +typedef union __attribute__((packed)) segment_attributes {
>>      uint16_t bytes;
>>      struct
>>      {
>> @@ -91,7 +91,7 @@ typedef union __packed segment_attributes {
>>   * Full state of a segment register (visible and hidden portions).
>>   * Again, this happens to match the format of an AMD SVM VMCB.
>>   */
>> -struct __packed segment_register {
>> +struct __attribute__((packed)) segment_register {
>>      uint16_t   sel;
>>      segment_attributes_t attr;
>>      uint32_t   limit;
> Please use __packed__ in both cases (using the underscore free
> variant is better to be restricted to just .c files). With that
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Will do.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel