Re: [Xen-devel] [PATCH 2/2] Partially revert 21550029f709072aacf3b90edd574e7d3021b400

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Oct 25, 2016 at 03:46:55PM -0700, Stefano Stabellini wrote:
> Commit 21550029f709072aacf3b90edd574e7d3021b400 removed the
> PLATFORM_QUIRK_GIC_64K_STRIDE quirk and introduced a way to
> automatically detect that the two GICC pages have a 64K stride.
> 
> However the heuristic requires that the device tree for the platform
> reports a GICC size == 128K, which is not the case for some versions of
> XGene.
> 
> Fix the issue by partially reverting
> 21550029f709072aacf3b90edd574e7d3021b400:
> 
> - reintroduce PLATFORM_QUIRK_GIC_64K_STRIDE for XGene
> - force csize to SZ_128K for mapping if PLATFORM_QUIRK_GIC_64K_STRIDE
> 
> Signed-off-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

Sounds like a reasonable approach to me.

Code-wise also looks good.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel