Re: [Xen-devel] [PATCH] xen:rtds: Update last_start whenever cur_budget is updated

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Wed, 2016-10-26 at 15:06 -0400, Meng Xu wrote:
> We keep last_start updated whenever cur_budget is updated.
> This avoids subtle bugs in case burn_budget() will be called
> in other places in the future.
> 
I'd change this into something like:

"Make budget accounting code more consistent by making sure the values
used to compute how much budget has been consumed are updated together.

This makes code resilient to calling burn_budget() from more than just
one place --in case we will need to do that-- without risking subtle
bugs."

Also, when that is the case, like here, you need to explicitly state
that no functional changes are intended.

With all this done to the changelog:

> Signed-off-by: Meng Xu <mengxu@xxxxxxxxxxxxx>
>
Acked-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>

This can go in 4.8, but can also well wait for 4.9.

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel