Re: [Xen-devel] [PATCH v2 1/7] xenstore: fix add_change_node()

[Juergen Gross <jgross@xxxxxxxx>]

On 27/10/16 12:15, Wei Liu wrote:
> On Thu, Oct 27, 2016 at 11:55:52AM +0200, Juergen Gross wrote:
>> add_change_node() in xenstored is used to add a modified node to the
>> list of changed nodes of one transaction. It is being called with the
>> recurse parameter set to true when removing a node in order to get
>> watches for children of the node fired at transaction end, too.
>>
>> If, however, the node to be deleted had been modified in the same
>> transaction the recurse parameter of add_change_node() is lost as
>> an entry already in the list of the changed nodes won't be entered
>> again.
>>
>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> 
> Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> I think we should apply this to 4.8, too. I will wait a bit for
> different opinions.
> 
> (I've only looked at this patch in this series because I caught the
> "fix" in subject line)

That's how it was meant to be. I just wanted to get some feedback
about the general idea before continuing the work on xenstored
(handling of memory allocation failures, more effective transaction
handling), as some of this work will be based on the per-node
generation counter I've introduced with this series.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel