[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 for-4.8] tools/libacpi: fix sed usage



On Mon, Oct 31, 2016 at 10:29:14AM +0000, Wei Liu wrote:
> On Mon, Oct 31, 2016 at 11:05:20AM +0100, Roger Pau Monne wrote:
> > Current usage of sed in the libacpi Makefile make uses of non-POSIX options,
> > that are not available on all the OSes supported by the Xen tools.
> > 
> > The '-i' option has slightly different semantics between GNU and BSD sed
> > implementations, while on the GNU version the suffix is optional, on the BSD
> > one it is not. Also BSD sed seems to have problems parsing the script
> > itself, reporting "extra characters at the end of d command".
> > 
> > Fix those issues by using a temporary intermediate file, and replace the
> > script with a simpler version that achieves the same purpose (removing the
> > initial license header comment).
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> 
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Applied.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.