Re: [Xen-devel] [PATCH v3.1 00/15] Initial PVHv2 Dom0 support

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

On Mon, Oct 31, 2016 at 02:43:08PM +0000, Andrew Cooper wrote:
> On 31/10/16 14:35, Boris Ostrovsky wrote:
> >
> >
> > On 10/29/2016 04:59 AM, Roger Pau Monne wrote:
> >> (resending as v3.1, it seems like I need to figure out how to
> >> properly use
> >> msmtp with git send-email because on the last try only the cover letter
> >> was actually sent).
> >>
> >> Hello,
> >>
> >> This is the first batch of the PVH Dom0 support eries, that includes
> >> everything up to the point where ACPI tables for he Dom0 are crafted.
> >> I've
> >> decided to left the last part of the series (the ne that contains the
> >> PCI
> >> config space handlers, and other mulation/trapping related code)
> >> separated,
> >> in order to focus and ease the review. This is f course not
> >> functional, one
> >> might be able to partially boot a Dom0 kernel if t doesn't try to access
> >> any physical device.
> >>
> >> Another reason for splitting this series is so hat I can write a proper
> >> design document about how this trapping is going o work, and what is it
> >> supposed to do, because during the last review ound I got the feeling
> >> that
> >> some comments where not really related to the ode itself, but to what
> >> I was
> >> trying to achieve, so it's best to discuss them n a design document
> >> rather
> >> than mixed up with code.
> >
> >
> > Given that we are dropping PVHv1 support from Linux and the fact that
> > v1 has always been a tech preview (or some such) should we drop it now?
> >
> > The is_pvh_domain() is getting more and more confusing.
> 
> +1 for dropping all the PVHv1 remnants from Xen.
> 
> Perhaps the start of 4.9 is the best time to flip this switch.

Yes, I don't have any objections to that. Perhaps it should be done after 
this series is in, since here I'm reusing some of the PVH code in 
domain_build.c (so removing PVH before committing this would force me to 
reintroduce those functions later on).

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel