[Xen-devel] [PATCH 11/12] xen: make use of xenbus_read_unsigned() in xen-pciback

[Juergen Gross <jgross@xxxxxxxx>]

Use xenbus_read_unsigned() instead of xenbus_scanf() when possible.
This requires to change the type of the read from int to unsigned,
but this case has been wrong before: negative values are not allowed
for the modified case.

Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
---
 drivers/xen/xen-pciback/xenbus.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c
index 5ce878c..3f0aee0 100644
--- a/drivers/xen/xen-pciback/xenbus.c
+++ b/drivers/xen/xen-pciback/xenbus.c
@@ -362,7 +362,7 @@ static int xen_pcibk_reconfigure(struct xen_pcibk_device 
*pdev)
        int err = 0;
        int num_devs;
        int domain, bus, slot, func;
-       int substate;
+       unsigned int substate;
        int i, len;
        char state_str[64];
        char dev_str[64];
@@ -395,10 +395,8 @@ static int xen_pcibk_reconfigure(struct xen_pcibk_device 
*pdev)
                                         "configuration");
                        goto out;
                }
-               err = xenbus_scanf(XBT_NIL, pdev->xdev->nodename, state_str,
-                                  "%d", &substate);
-               if (err != 1)
-                       substate = XenbusStateUnknown;
+               substate = xenbus_read_unsigned(pdev->xdev->nodename, state_str,
+                                               XenbusStateUnknown);
 
                switch (substate) {
                case XenbusStateInitialising:
-- 
2.6.6


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel