Re: [Xen-devel] [PATCH 08/12] xen: make use of xenbus_read_unsigned() in xen-pcifront

[Bjorn Helgaas <helgaas@xxxxxxxxxx>]

On Mon, Oct 31, 2016 at 05:48:26PM +0100, Juergen Gross wrote:
> Use xenbus_read_unsigned() instead of xenbus_scanf() when possible.
> This requires to change the type of the read from int to unsigned,
> but this case has been wrong before: negative values are not allowed
> for the modified case.
> 
> Cc: bhelgaas@xxxxxxxxxx
> Cc: linux-pci@xxxxxxxxxxxxxxx
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>

I assume this will be merged with the rest of the series via some tree
other than mine.

> ---
>  drivers/pci/xen-pcifront.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c
> index d6ff5e8..8fc2e95 100644
> --- a/drivers/pci/xen-pcifront.c
> +++ b/drivers/pci/xen-pcifront.c
> @@ -1038,10 +1038,8 @@ static int pcifront_detach_devices(struct 
> pcifront_device *pdev)
>                       err = -ENOMEM;
>                       goto out;
>               }
> -             err = xenbus_scanf(XBT_NIL, pdev->xdev->otherend, str, "%d",
> -                                &state);
> -             if (err != 1)
> -                     state = XenbusStateUnknown;
> +             state = xenbus_read_unsigned(pdev->xdev->otherend, str,
> +                                          XenbusStateUnknown);
>  
>               if (state != XenbusStateClosing)
>                       continue;
> -- 
> 2.6.6
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel