Re: [Xen-devel] [PATCH for-4.8] libxc/x86: Report consistent initial APIC value for PV guests

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Nov 11, 2016 at 03:33:11PM +0000, Andrew Cooper wrote:
> On 11/11/16 15:32, Jan Beulich wrote:
> >>>> On 11.11.16 at 16:16, <wei.liu2@xxxxxxxxxx> wrote:
> >> On Thu, Nov 10, 2016 at 09:50:24AM -0500, Boris Ostrovsky wrote:
> >>> Currently hypervisor provides PV guest's CPUID(1).EBX[31:24] (initial
> >>> APIC ID) with contents of that field on the processor that launched
> >>> the guest. This results in the guest reporting different initial
> >>> APIC IDs across runs.
> >>>
> >>> We should be consistent in how this value is reported, let's set
> >>> it to 0 (which is also what Linux guests expect).
> >>>
> >>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> >> I will defer this to x86 maintainers.
> > Changing from a random (wrong) value to a deterministic (but still
> > wrong) value certainly won't make things worse. IOW the patch
> > can have my ack if needed, but I thought I had seen Andrew
> > already give his.
> 
> I don't think I had explicitly, but here...
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Applied.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel