[Xen-devel] [PATCH 00/35] libxl LOG*D functions

[Cédric Bosdonnat <cbosdonnat@xxxxxxxx>]

Hi all,

This patch series adds a LOG*D family matching the existing
LOG* one, but with one more parameter for the domain ID.
Using this new family will allow the libxl-based applications
to sort log entries by domain ID. For example a typical use
case of this is  the libvirt libxl driver: it should output
one log file per domain as done by other libvirt drivers.

The first patch of the series adds the the LOG*D functions,
the other ones are to convert the existing LOG* calls to LOG*D
when possible.

I'm new to the xen code base, and I may have used the wrong
value for the publicly know domain ID in some places.

I also have changed some log messages that where already
including the domain ID... I'm not sure whether this is
a good idea or not.

Note that I have made one commit per changed file as it
would ease maintenance, and the values used for the domain ID
are generally consistent within each file. However, I have
split the libxl.c file into several commits to ease reviewing
that giant change.

As these changes where all manually done, there is no
script to document here.

Cédric Bosdonnat (35):
  libxl: add LIBXL_LOGD_* and LOG*D function families.
  libxl.c: switch to LOG*D use
  libxl.c: switch to LOG*D use (refactored messages)
  libxl.c: switch to LOG*D use (refactored messages)
  libxl/libxl_bootloader.c: used LOG*D functions
  libxl/libxl_checkpoint_device.c: used LOG*D functions
  libxl/libxl_colo.h: used LOG*D functions
  libxl/libxl_colo_nic.c: used LOG*D functions
  libxl/libxl_colo_proxy.c: used LOG*D functions
  libxl/libxl_colo_qdisk.c: used LOG*D functions
  libxl/libxl_colo_restore.c: used LOG*D functions
  libxl/libxl_colo_save.c: used LOG*D functions
  libxl/libxl_create.c: used LOG*D functions
  libxl/libxl_device.c: used LOG*D functions
  libxl/libxl_dm.c: used LOG*D functions
  libxl/libxl_dom_save.c: used LOG*D functions
  libxl/libxl_dom_suspend.c: used LOG*D functions
  libxl/libxl_freebsd.c: used LOG*D functions
  libxl/libxl_internal.c: used LOG*D functions
  libxl/libxl_linux.c: used LOG*D functions
  libxl/libxl_netbsd.c: used LOG*D functions
  libxl/libxl_netbuffer.c: used LOG*D functions
  libxl/libxl_nic.c: used LOG*D functions
  libxl/libxl_no_colo.c: used LOG*D functions
  libxl/libxl_pci.c: used LOG*D functions
  libxl/libxl_psr.c: used LOG*D functions
  libxl/libxl_pvusb.c: used LOG*D functions
  libxl/libxl_qmp.c: used LOG*D functions
  libxl/libxl_remus.c: used LOG*D functions
  libxl/libxl_save_callout.c: used LOG*D functions
  libxl/libxl_stream_write.c: used LOG*D functions
  libxl/libxl_vnuma.c: used LOG*D functions
  libxl/libxl_vtpm.c: used LOG*D functions
  libxl/libxl_x86.c: used LOG*D functions
  libxl/libxl_xshelp.c: used LOG*D functions

 tools/libxl/libxl.c                   | 499 +++++++++++++++++-----------------
 tools/libxl/libxl_bootloader.c        |  84 +++---
 tools/libxl/libxl_checkpoint_device.c |  14 +-
 tools/libxl/libxl_colo.h              |   2 +-
 tools/libxl/libxl_colo_nic.c          |   2 +-
 tools/libxl/libxl_colo_proxy.c        |  24 +-
 tools/libxl/libxl_colo_qdisk.c        |   2 +-
 tools/libxl/libxl_colo_restore.c      |  57 ++--
 tools/libxl/libxl_colo_save.c         |  49 ++--
 tools/libxl/libxl_create.c            | 119 ++++----
 tools/libxl/libxl_device.c            |  70 ++---
 tools/libxl/libxl_dm.c                | 111 ++++----
 tools/libxl/libxl_dom_save.c          |  29 +-
 tools/libxl/libxl_dom_suspend.c       |  45 ++-
 tools/libxl/libxl_event.c             |   6 +-
 tools/libxl/libxl_freebsd.c           |   8 +-
 tools/libxl/libxl_internal.c          |  45 +--
 tools/libxl/libxl_internal.h          |  38 ++-
 tools/libxl/libxl_linux.c             |  23 +-
 tools/libxl/libxl_netbsd.c            |   9 +-
 tools/libxl/libxl_netbuffer.c         |  43 +--
 tools/libxl/libxl_nic.c               |   9 +-
 tools/libxl/libxl_no_colo.c           |   4 +-
 tools/libxl/libxl_pci.c               | 153 ++++++-----
 tools/libxl/libxl_psr.c               |  12 +-
 tools/libxl/libxl_qmp.c               |  56 ++--
 tools/libxl/libxl_remus.c             |  27 +-
 tools/libxl/libxl_save_callout.c      |   8 +-
 tools/libxl/libxl_stream_write.c      |  10 +-
 tools/libxl/libxl_usb.c               |  57 ++--
 tools/libxl/libxl_vnuma.c             |   2 +-
 tools/libxl/libxl_vtpm.c              |   8 +-
 tools/libxl/libxl_x86.c               |   6 +-
 tools/libxl/libxl_xshelp.c            |   4 +-
 34 files changed, 856 insertions(+), 779 deletions(-)

-- 
2.10.1


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel