Re: [Xen-devel] [PATCH 2/6] x86/vpmu: Move vpmu_do_cpuid() handling into {pv, hvm}_cpuid()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.11.16 at 13:31, <andrew.cooper3@xxxxxxxxxx> wrote:
> This reduces the net complexity of CPUID handling by having all adjustments in
> at the same place.  Remove the now-unused vpmu_do_cpuid() infrastructure.

I have to admit that I'm not convinced this is a good idea at this point,
due to the added redundancy. Iirc your plan is to combine hvm_cpuid()
and pv_cpuid() anyway, at which point the folding done here would be
quite a bit more natural.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel