Re: [Xen-devel] [PATCH] x86/svm: Improve segment register printing in svm_vmcb_dump()

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 11/16/2016 08:43 AM, Andrew Cooper wrote:
> On 31/10/16 13:48, Andrew Cooper wrote:
>> This makes it more succinct and easier to read.
>>
>> Before:
>>   (XEN) H_CR3 = 0x000000042a0ec000 CleanBits = 0
>>   (XEN) CS: sel=0x0008, attr=0x029b, limit=0xffffffff, 
>> base=0x0000000000000000
>>   (XEN) DS: sel=0x0033, attr=0x0cf3, limit=0xffffffff, 
>> base=0x0000000000000000
>>   (XEN) SS: sel=0x0018, attr=0x0c93, limit=0xffffffff, 
>> base=0x0000000000000000
>>   (XEN) ES: sel=0x0033, attr=0x0cf3, limit=0xffffffff, 
>> base=0x0000000000000000
>>   (XEN) FS: sel=0x0033, attr=0x0cf3, limit=0xffffffff, 
>> base=0x0000000000000000
>>   (XEN) GS: sel=0x0033, attr=0x0cf3, limit=0xffffffff, 
>> base=0x0000000000000000
>>   (XEN) GDTR: sel=0x0000, attr=0x0000, limit=0x00000067, 
>> base=0x000000000010d100
>>   (XEN) LDTR: sel=0x0000, attr=0x0000, limit=0x00000000, 
>> base=0x0000000000000000
>>   (XEN) IDTR: sel=0x0000, attr=0x0000, limit=0x00000fff, 
>> base=0x0000000000110900
>>   (XEN) TR: sel=0x0038, attr=0x0089, limit=0x00000067, 
>> base=0x000000000010d020
>>
>> After:
>>   (XEN) H_CR3 = 0x000000042a0ec000 CleanBits = 0
>>   (XEN)        sel  attr  limit   base
>>   (XEN)   CS: 0008 0029b ffffffff 0000000000000000
>>   (XEN)   DS: 0033 00cf3 ffffffff 0000000000000000
>>   (XEN)   SS: 0018 00c93 ffffffff 0000000000000000
>>   (XEN)   ES: 0033 00cf3 ffffffff 0000000000000000
>>   (XEN)   FS: 0033 00cf3 ffffffff 0000000000000000
>>   (XEN)   GS: 0033 00cf3 ffffffff 0000000000000000
>>   (XEN) GDTR: 0000 00000 00000067 000000000010d100
>>   (XEN) LDTR: 0000 00000 00000000 0000000000000000
>>   (XEN) IDTR: 0000 00000 00000fff 0000000000110900
>>   (XEN)   TR: 0038 00089 00000067 000000000010d020
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> ---
>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>> CC: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
>> CC: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> AMD Ping?

Sorry, I thought you were going to respin with updated attribute format
but I should have responded anyway.

Reviewed-by: Boris Ostrovsky <boris.ostorvsky@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel