Re: [Xen-devel] [OSSTEST PATCH v7 3/3] Create a flight to test OpenStack with xen-unstable and libvirt

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Anthony PERARD writes ("[Xen-devel] [OSSTEST PATCH v7 3/3] Create a flight to 
test OpenStack with xen-unstable and libvirt"):
> This patch should create a flight "openstack-nova", with those jobs:

Did I already ask for a diff of the output of
   standalone-generate-dump-flight-runvars
before and after ?

You probably want
  AP_FETCH_PLACEHOLDERS=y eatmydata ./standalone-generate-dump-flight-runvars

Your new shell code is mostly good.  I have a style comment:

> +define_openstack_trees() {
> +    local openstack_trees=(cinder glance keystone nova requirements tempest)

The use of an array variable here is not necessary since none of these
contain spaces.  I don't object, except that:

> +    for tree in ${openstack_trees[@]}; do

This sets off my style alarm because of the lack of "" around a
${something[@]} (which off course doesn't matter here.

Can you either add the " ", or switch to a plain (space-separated)
variable.

> +    for tree in ${openstack_trees[@]}; do

Here too.

Aside from that, and assuming the runvars diff is good, this is
looking good.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel