[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2] OvmfPkg/build.sh: Make GCC5 the default toolchain, catch GCC43 and earlier
On 11/23/16 15:55, Laszlo Ersek wrote: > On 11/23/16 03:36, Konrad Rzeszutek Wilk wrote: >> From Laszlo: >> " change the catch-all (*) to GCC5, from GCC44 >> - remove the (5.*.*) pattern from GCC49 >> - add a branch (with multiple patterns if necessary) for gcc-4.3 and >> earlier to exit with an error message / failure (those compiler >> versions are unsupported)" >> >> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=62 >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx> >> --- >> v1: First submission >> v2: Redo it per Laszlo suggestion. >> >> OvmfPkg/build.sh | 11 +++++++++-- >> 1 file changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh >> index eb5eb73..cab7c70 100755 >> --- a/OvmfPkg/build.sh >> +++ b/OvmfPkg/build.sh >> @@ -83,6 +83,13 @@ case `uname` in >> Linux*) >> gcc_version=$(gcc -v 2>&1 | tail -1 | awk '{print $3}') >> case $gcc_version in >> + 4.1.[0-0].*|4.2.*|4.3.*) > > * The [0-0] bracketed expression will work as expected, but it's > somewhat unusual :) Is it intentional? > > * If it's a typo, are you okay if I replace it with a plain 0 on commit? On a second thought, perhaps you meant 4.0.*|4.1.*|4.2.*|4.3.*) or 4.[0-3].*) If you wish to re-submit for this, we could consider those pre-4 releases as well: [1-3].*|4.[0-3].*) Thanks! Laszlo > * Also, IIRC, Olaf considered pre-4.0 gcc releases as well (rejecting > them of course), which is sort of meant as part of "gcc-4.3 and > earlier". But, given your extensive testing with old distros (thanks for > that!), I think it's safe to ignore pre-4.0 gcc releases altogether. > > Reviewed-by: Laszlo Ersek <lersek@xxxxxxxxxx> > > Thanks! > Laszlo > >> + echo OvmfPkg requires GCC4.4 or later >> + exit 1 >> + ;; >> + 4.4.*) >> + TARGET_TOOLS=GCC44 >> + ;; >> 4.5.*) >> TARGET_TOOLS=GCC45 >> ;; >> @@ -95,11 +102,11 @@ case `uname` in >> 4.8.*) >> TARGET_TOOLS=GCC48 >> ;; >> - 4.9.*|4.1[0-9].*|5.*.*) >> + 4.9.*) >> TARGET_TOOLS=GCC49 >> ;; >> *) >> - TARGET_TOOLS=GCC44 >> + TARGET_TOOLS=GCC5 >> ;; >> esac >> esac >> > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |