Re: [Xen-devel] [PATCH 13/15] x86/hvm: Avoid __hvm_copy() raising #PF behind the emulators back

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 23/11/16 16:39, Tim Deegan wrote:
> At 15:38 +0000 on 23 Nov (1479915536), Andrew Cooper wrote:
>> Drop the call to hvm_inject_page_fault() in __hvm_copy(), and require callers
>> to inject the pagefault themselves.
>>
>> No functional change.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> index afacd5f..88d4642 100644
>> --- a/xen/arch/x86/mm/shadow/common.c
>> +++ b/xen/arch/x86/mm/shadow/common.c
>> @@ -198,6 +198,7 @@ hvm_read(enum x86_segment seg,
>>      case HVMCOPY_okay:
>>          return X86EMUL_OKAY;
>>      case HVMCOPY_bad_gva_to_gfn:
>> +        hvm_inject_page_fault(pfinfo.ec, pfinfo.linear);
>>          return X86EMUL_EXCEPTION;
>>      case HVMCOPY_bad_gfn_to_mfn:
>>      case HVMCOPY_unhandleable:
> Should this also be converted to pass the injection to the emulator
> rather than injecting it directly?

Yes.

emulate_gva_to_mfn() also needs similar treatment, but will include some
PV pagetable fun as well.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel