Re: [Xen-devel] [Embedded-pv-devel] [PATCH v9] xen: add para-virtual sound interface header files

[Julien Grall <julien.grall@xxxxxxx>]

Hi Oleksandr,

On 23/11/16 16:38, Oleksandr Andrushchenko wrote:
> diff --git a/include/xen/interface/io/sndif_linux.h 
> b/include/xen/interface/io/sndif_linux.h
> new file mode 100644
> index 0000000..2802504
> --- /dev/null
> +++ b/include/xen/interface/io/sndif_linux.h
> @@ -0,0 +1,112 @@
> +/******************************************************************************
> + * sndif_linux.h
> + *
> + * Unified sound-device I/O interface for Xen guest OSes.
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a copy
> + * of this software and associated documentation files (the "Software"), to
> + * deal in the Software without restriction, including without limitation the
> + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> + * DEALINGS IN THE SOFTWARE.
> + *
> + * Copyright (C) 2016 EPAM Systems Inc.
> + *
> + * Authors: Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
> + *          Oleksandr Grytsov <al1img@xxxxxxxxx>
> + */
> +
> +#ifndef __XEN_PUBLIC_IO_XENSND_LINUX_H__
> +#define __XEN_PUBLIC_IO_XENSND_LINUX_H__
> +
> +#include <xen/interface/io/ring.h>
> +#include <xen/interface/io/sndif.h>
> +#include <xen/interface/grant_table.h>
> +
> +struct xensnd_open_req {
> +       uint32_t pcm_rate;
> +       uint8_t pcm_format;
> +       uint8_t pcm_channels;
> +       /* in Hz */
It is not clear to me to which field this comment applies. Is it 
pcm_channels?
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel