Re: [Xen-devel] [PATCH v10] xen: add para-virtual sound interface header file

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.11.16 at 17:01, <andr2000@xxxxxxxxx> wrote:
> +struct xensnd_close_req {
> +};

I'm afraid structures without any members aren't permitted by C89.

> +struct xensnd_request {
> +     uint8_t raw[64];
> +};
> +
> +struct xensnd_response {
> +     uint8_t raw[64];
> +};

What are these two needed for now? If you want to enforce a
minimum size, that would better go ...

> +union xensnd_req {
> +     struct xensnd_request raw;
> +     struct {
> +             uint16_t id;
> +             uint8_t operation;
> +             uint8_t stream_idx;
> +             uint32_t padding;
> +             union {
> +                     struct xensnd_open_req open;
> +                     struct xensnd_close_req close;
> +                     struct xensnd_write_req write;
> +                     struct xensnd_read_req read;
> +                     struct xensnd_get_vol_req get_vol;
> +                     struct xensnd_set_vol_req set_vol;
> +                     struct xensnd_mute_req mute;
> +                     struct xensnd_unmute_req unmute;

... here.

Also please observe ./CODING_STYLE (we don't use tabs for
indentation).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel