[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 06/15] x86/emul: Rework emulator event injection



At 00:25 -0700 on 25 Nov (1480033543), Jan Beulich wrote:
> >>> On 24.11.16 at 18:37, <andrew.cooper3@xxxxxxxxxx> wrote:
> > As an interim between now and getting a proper audit hook, would a bool
> > permit_traps in x86_emulate_ctxt suffice?
> 
> That's one option; the other would be to do away with only the
> exception injection hook for now, and keep the swint one. That's
> effectively the same as the boolean flag, just with less overall
> code churn (and keeping the hook would not undermine this
> series' goal of eliminating event injection behind the back of the
> emulator).

I'd be OK with either of those.  Or indeed with
 - adjusting the emulator so it always returns a non-OK value when it
   needs the caller to do something to make the state consistent; or
 - keeping the injection hook but moving it to the end of the
   emulation, as a sort of write-back of the emulator's internal event
   state to the guest.  That would let the emulator DTRT about
   tracking events internally but still avoid any risk that the caller
   forgets to inject the event.

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.