Re: [Xen-devel] [PATCH v3 04/15] x86: refactor psr: Encapsulate 'cbm_len' and 'cbm_max'

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.10.16 at 05:40, <yi.y.sun@xxxxxxxxxxxxxxx> wrote:
> 'cbm_len' and 'cbm_max' are CAT/CDP specific feature HW info.
> So encapsulate them into 'struct psr_cat_hw_info'. If new
> feature is supported, we can define other structure to save
> its HW info.

Part of my problem following you here is that you talk about
cbm_max, but the code changes cos_max, which so far I had
understood would be a generic limit, which appears to be
supported by ...

> @@ -26,9 +26,14 @@
>  /* Per spec, the maximum COS register number is 128. */
>  #define MAX_COS_REG_NUM  128
>  
> -struct psr_cat_socket_info {
> +/* CAT/CDP HW info data structure. */
> +struct psr_cat_hw_info {
>      unsigned int cbm_len;
>      unsigned int cos_max;
> +};
> +
> +struct psr_cat_socket_info {
> +    struct psr_cat_hw_info l3_info;
>      /*
>       * Store the values of COS registers:
>       * CAT uses 1 entry for one COS ID;

... you leaving this comment in place.

Btw., perhaps it would also help if psr.c had (near its beginning) a
glossary of the various acronyms. By having a way to quickly refresh
one's memory of what COS, CAT, CBM, and who know what else
stand for, it might be a little easier to reason about changes like this
one.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel