Re: [Xen-devel] [PATCH for-4.8] tools/libacpi: Fix compilation when cross building the tools

[Jungseok Lee <jungseoklee85@xxxxxxxxx>]

On Nov 26, 2016, at 4:06 AM, Julien Grall wrote:

Hi Julien and Xen folks,

> The tools (such as mk_dsdt) can be cross-built when it may not be
> desirable to build them on the target.
> 
> The commit c4ac1077 "libxl/arm: Generate static ACPI DSDT table"
> introduced support of ARM64 in mk_dsdt but also break cross-building
> tools because the ACPI tables are not correct.
> 
> While mk_dsdt should generate ACPI table for the target architecture, it
> currently generates the one for the host. This is because the source
> code contains reference to the host architecture (__aarch64__,
> __x86_64__, __i386__) when it should be the target architecture.
> 
> Replace all __aarch64__, __x86_64__, __i386__ by the corresponding
> CONFIG_*.
> 
> Also expose the CONFIG_* to the source code as the currently only
> exposed to the Makefile.
> 
> Reported-by: Andrii Anisov <andrii.anisov@xxxxxxxxx>
> Suggested-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> 
> ---
>    This was reported on the ML recently (see [1]) and affects only Xen
>    4.8. Without this patch, cross-building the tools will not work.
> 
>    I think this patch is quite important for embedded users where they
>    tend to cross-build the rootfs (for instance using yocto).

I've experienced the same build breakage when using Yocto. This patch
resolves the problem in my case. Thanks a lot!

Best Regards
Jungseok Lee

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel