Re: [Xen-devel] [PATCH v10 09/13] x86: change default load address from 1 MiB to 2 MiB

[Juergen Gross <jgross@xxxxxxxx>]

On 30/11/16 14:51, Juergen Gross wrote:
> On 30/11/16 14:04, Daniel Kiper wrote:
>> Subsequent patches introducing relocatable early boot code play with
>> page tables using 2 MiB huge pages. If load address is not aligned at
>> 2 MiB then code touching such page tables must have special cases for
>> start and end of Xen image memory region. So, let's make life easier
>> and move default load address from 1 MiB to 2 MiB. This way page table
>> code will be nice and easy. Hence, there is a chance that it will be
>> less error prone too... :-)))
>>
>> Additionally, drop first 2 MiB mapping from Xen image mapping.
>> It is no longer needed.
>>
>> Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
>> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> v8 - suggestions/fixes:
>>    - drop first 2 MiB mapping from Xen image mapping
>>      (suggested by Jan Beulich),
>>    - improve commit message.
>>
>> v7 - suggestions/fixes:
>>    - minor cleanups
>>      (suggested by Jan Beulich).
>> ---
>>  xen/arch/x86/Makefile      |    2 +-
>>  xen/arch/x86/Rules.mk      |    3 +++
>>  xen/arch/x86/boot/head.S   |    8 --------
>>  xen/arch/x86/boot/x86_64.S |    5 +++--
>>  xen/arch/x86/setup.c       |    3 ++-
>>  xen/arch/x86/xen.lds.S     |    2 +-
>>  6 files changed, 10 insertions(+), 13 deletions(-)
>>
>> diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile
>> index e74fe62..d5d0651 100644
>> --- a/xen/arch/x86/Makefile
>> +++ b/xen/arch/x86/Makefile
>> @@ -90,7 +90,7 @@ all_symbols =
>>  endif
>>  
>>  $(TARGET): $(TARGET)-syms $(efi-y) boot/mkelf32
>> -    ./boot/mkelf32 $(notes_phdrs) $(TARGET)-syms $(TARGET) 0x100000 \
>> +    ./boot/mkelf32 $(notes_phdrs) $(TARGET)-syms $(TARGET) 
>> $(XEN_IMG_OFFSET) \
>>                     `$(NM) $(TARGET)-syms | sed -ne 's/^\([^ ]*\) . 
>> __2M_rwdata_end$$/0x\1/p'`
> 
> This doesn't apply (somehow you managed to insert spaces into the patch
> file).

Sorry for the noise, somehow I managed to skip patch 4.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel