Re: [Xen-devel] [PATCH v3 10/24] x86/emul: Always use fault semantics for software events

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.12.16 at 12:15, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 01/12/16 10:53, Jan Beulich wrote:
>>> --- a/xen/arch/x86/x86_emulate/x86_emulate.c
>>> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c
>>> @@ -1694,8 +1694,6 @@ static int inject_swint(enum x86_swint_type type,
>>>                      goto raise_exn;
>>>              }
>>>          }
>>> -
>>> -        ctxt->regs->eip += insn_len;
>>>      }
>>>  
>>>      rc = ops->inject_sw_interrupt(type, vector, insn_len, ctxt);
>> I think for the patch description to be correct, this call's return value
>> needs to be altered, for inject_swint() to return EXCEPTION when
>> OKAY comes back here (which iirc you do in a later patch when you
>> eliminate this hook).
> 
> At the moment, the sole user is
> 
>     swint:
>         rc = inject_swint(swint_type, (uint8_t)src.val,
>                           _regs.eip - ctxt->regs->eip,
>                           ctxt, ops) ? : X86EMUL_EXCEPTION;
>         goto done;
> 
> so the description is correct.

Oh - I should have checked the caller. Sorry for the noise.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel