[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 2/3] Add Xen colo support for qemu-upstream colo codes
On Wed, Nov 30, 2016 at 05:47:51PM +0800, Zhang Chen wrote: > Because of qemu codes update, we update Xen colo block codes > > Signed-off-by: Zhang Chen <zhangchen.fnst@xxxxxxxxxxxxxx> COLO being an experimental feature means that you can change it at will, so for both patches: Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx> But, this sort of patch does make me wonder how QEMU handles backward compatibility for command line options... > --- > tools/libxl/libxl_colo_qdisk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/libxl/libxl_colo_qdisk.c b/tools/libxl/libxl_colo_qdisk.c > index d271d1f..300bff2 100644 > --- a/tools/libxl/libxl_colo_qdisk.c > +++ b/tools/libxl/libxl_colo_qdisk.c > @@ -169,9 +169,9 @@ static void colo_qdisk_save_preresume(libxl__egc *egc, > /* qmp command doesn't support the driver "nbd" */ > node = GCSPRINTF("colo_node%d", > libxl__device_disk_dev_number(disk->vdev, NULL, NULL)); > - cmd = GCSPRINTF("drive_add buddy driver=replication,mode=primary," > + cmd = GCSPRINTF("drive_add -n buddy driver=replication,mode=primary," > "file.driver=nbd,file.host=%s,file.port=%d," > - "file.export=%s,node-name=%s,if=none", > + "file.export=%s,node-name=%s", > host, port, export_name, node); > ret = libxl__qmp_hmp(gc, domid, cmd, NULL); > if (ret) > -- > 2.7.4 > > > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |