Re: [Xen-devel] [PATCH] AMD IOMMU: Support IOAPIC IDs larger than 128

[Suravee Suthikulpanit <Suravee.Suthikulpanit@xxxxxxx>]

Hi Jan,

On 12/1/16 18:58, Jan Beulich wrote:
> > > > On 01.12.16 at 12:04, <suravee.suthikulpanit@xxxxxxx> wrote:
> > @@ -1028,15 +1036,15 @@ static int __init parse_ivrs_table(struct 
> > acpi_table_header *table)
> >          if ( !nr_ioapic_entries[apic] )
> >              continue;
> >
> > -        if ( !ioapic_sbdf[IO_APIC_ID(apic)].seg &&
> > +        if ( !ioapic_sbdf[apic].seg &&
> Can apic really be used as array index here? Don't you need to look
> up the index via ioapic_id_to_index()?
I'll fix this. Thanks.

> Or otherwise wouldn't it make
> sense to use the same array slots for a particular IO-APIC in both
> nr_ioapic_entries[] and ioapic_sbdf[], instead of allocating them via
> get_next_ioapic_bdf_index()?
Isn't the ivrs_ioapic option get parsed before the nr_ioapic_entries are 
created?
Thanks,
Suravee


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel