[Xen-devel] [PATCH v4 07/12] xenstore: use array for xenstore wire command handling

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.12.16 at 08:48, <JGross@xxxxxxxx> wrote:
> @@ -1304,12 +1275,51 @@ static void do_debug(struct connection *conn, struct 
> buffered_data *in)
>       send_ack(conn, XS_DEBUG);
>  }
>  
> +static struct {
> +     char *str;
> +     void (*func)(struct connection *conn, struct buffered_data *in);
> +} wire_funcs[XS_TYPE_COUNT] = {

If this was hypervisor code, I would demand both the array as a
whole and the str member to become constified. Not sure what the
tool stack side non-library policy is.

> --- a/xen/include/public/io/xs_wire.h
> +++ b/xen/include/public/io/xs_wire.h
> @@ -52,6 +52,8 @@ enum xsd_sockmsg_type
>      XS_RESET_WATCHES,
>      XS_DIRECTORY_PART,
>  
> +    XS_TYPE_COUNT,      /* Number of valid types. */
> +
>      XS_INVALID = 0xffff /* Guaranteed to remain an invalid type */
>  };

This as well as the XS_DIRECTORY_PART addition in patch 5 can
have my ack, if needed (albeit I guess the tool stack maintainers'
will do).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel