Re: [Xen-devel] [PATCH 2/2] x86/debugtrace: Introduce a reset debugkey

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.12.16 at 11:02, <andrew.cooper3@xxxxxxxxxx> wrote:
> When tracing a difference between two runs, it can be useful to reset the
> trace count to help identify where the two traces diverge.
> 
> Move the count outside debugtrace_printk() it can be reset.  Inline
> debugtrace_toggle() into its single caller, so its prologue and epilogue can
> be reused.  Register a second keyhandler pointing at debugtrace_key(), and
> select the action based on the key used.

I think we need to start becoming more conservative with introducing
new debug keys, as there aren't that many unused ones left. Hence a
first question here would be - would a sysctl do as a replacement? In
which case I'd question whether instead of adding another key we
could also get rid of 'T' this same way.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel