Re: [Xen-devel] [PATCH] xen/arm: Remove unused tnode variables in DT IRQ map parsing

[Artem Mygaiev <artem_mygaiev@xxxxxxxx>]

On 06.12.16 16:37, Julien Grall wrote:
>
>
> On 06/12/16 14:33, Artem Mygaiev wrote:
>> Hi Julien
>>
>>
>> On 06.12.16 16:19, Julien Grall wrote:
>>> Hi Artem,
>>>
>>> On 06/12/16 13:57, Artem Mygaiev wrote:
>>>> Remove unused tnode variables in device tree IRQ map parsing
>>>
>>> This description is slightly wrong, the variable are used but not the value.
>> True
>>>
>>>> Coverity-ID 1381866, 1381867
>>>>
>>>> Signed-off-by: Artem Mygaiev <artem_mygaiev@xxxxxxxx>
>>>
>>> This code is from Linux (see drivers/of/irq.c) and I would prefer to keep 
>>> it very similar as long as it does not lead to a bug:
>> I understand, but in the kernel code tnode is used to safely decrement kobj 
>> refcount (e.g. in 4.8.12):
>>
>>  144                tnode = of_get_parent(old);
>>  145                of_node_put(old);
>>  146                old = tnode;
>>
>> AFAIU in Xen refcounts are dropped, so probably tnode can be dropped as a 
>> part of the infrastructure... no?
>
> I have an item in my todo list to re-sync the device-tree code with Linux. So 
> we have a proper copy rather than a modified one.
Oh, I see, thanks.
>
> Meanwhile, I would strongly prefer to keep this code as close as possible 
> from Linux. This tnode variable is harmless, so I stand on what I said.
>
> Regards,
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel