Re: [Xen-devel] [PATCH v4 11/15] pvh: Send an SCI on VCPU hotplug event

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 12/06/2016 09:50 AM, Jan Beulich wrote:
>>
>> +
>> +            /*
>> +             * If a new bit has been set in status register and 
>> corresponding
>> +             * event is enabled then an SCI is sent to the guest.
>> +             */
>> +            if ( !is_guest_access &&
>> +                 ((*sts ^ sts_orig) & ~sts_orig) && (*sts & *en))
>> +                send_guest_global_virq(d, VIRQ_SCI);
> I don't think comment and condition match; namely the
> "corresponding" doesn't appear to be fulfilled - you raise
> SCI if any bit is set both in *sts and *en.

Oh, that was just wrong. Should be (taking your simplification below in
to account)
    (*sts & ~sts_orig) & *en

-boris

>
> Also (a ^ b) & ~b = a & ~b afaict.
>
> Jan
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel