[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 2/2] x86emul: correct 64-bit mode repeated string insn handling with zero count
On 06/12/16 13:39, Jan Beulich wrote: > When a 32-bit address override is in effect these zero-extend all > registers which would also get updated in case of non-zero repeat > count. > > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>. However, > @@ -5424,7 +5436,6 @@ x86_emulate( > goto cannot_emulate; > } > > - writeback: This removal highlights that the writeback and no_writeback lables are incorrectly named. There intended meaning is {no,}dest_writeback, but no_writeback still performs a full commit of the shadow GPR state, which is what people logically associate with the term "writeback" in this context. I think we should have a followup patch renaming the no_writeback label to to gpr_writeback. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |