Re: [Xen-devel] [PATCH v11 08/13] x86/boot: implement early command line parser in C

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.12.16 at 00:08, <daniel.kiper@xxxxxxxxxx> wrote:
> On Wed, Dec 07, 2016 at 06:27:58PM +0100, Daniel Kiper wrote:
>> On Wed, Dec 07, 2016 at 06:43:40AM -0700, Jan Beulich wrote:
>> > >>> On 05.12.16 at 23:25, <daniel.kiper@xxxxxxxxxx> wrote:
>> > > Current early command line parser implementation in assembler
>> > > is very difficult to change to relocatable stuff using segment
>> > > registers. This requires a lot of changes in very weird and
>> > > fragile code. So, reimplement this functionality in C. This
>> > > way code will be relocatable out of the box (without playing
>> > > with segment registers) and much easier to maintain.
>> > >
>> > > Additionally, put all common cmdline.c and reloc.c definitions
>> > > into defs.h header. This way we do not duplicate needlessly
>> > > some stuff.
>> > >
>> > > And finally remove unused xen/include/asm-x86/config.h
>> > > header from reloc.c dependencies.
>> > >
>> > > Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> > > Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
>> > > Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>> >
>> > As you may have seen I've applied patches 2..4. I would also
>>
>> Great! Thanks a lot!
>>
>> > have applied this one, but it fails to apply cleanly. Whether
>> > that's because it needs re-basing or because it can't be applied
>> > out of order I can't tell. In order for you to not have to re-submit
> 
> I have checked it. It requires at least some changes made by patch #1 which
> has "Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>". Of course I can change
> this but then I think that I should drop your Reviewed-by from #1 and your
> Acked-by from #8.

Unless you change the structure of the code you move, I don't think
either of the tags would require dropping.

> Does it pays? I think that we can do that in a bit different
> way. If there are no more comments please apply everything as is.

I think Andrew and I are in agreement that we're not at the point
yet where everything can go in as is. Please be patient - this has
taken so long to get where it is now that I don't think there's a
reason to rush anything now. And you may have noticed that
there have been quite a few other patch submissions which also
all want dealing with. Andrew and I should also be allowed some
room to actually do some work of our own ...

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel