[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC v2 2/7] x86emul/test: factor out emul_test_make_stack_executable



>>> On 09.12.16 at 13:23, <wei.liu2@xxxxxxxxxx> wrote:
> @@ -18,4 +20,24 @@
>  #define get_stub(stb) ((void *)((stb).addr = (uintptr_t)(stb).buf))
>  #define put_stub(stb)
>  
> +bool emul_test_make_stack_executable(void)
> +{
> +    unsigned long sp;
> +    bool stack_exec;

I'd prefer for this local variable to be removed as unnecessary, but
in the end the patch can have my ack either way.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.