Re: [Xen-devel] [PATCH RFC v2 3/7] x86emul/test: factor out emul_test_{read_cr, cpuid}

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Dec 09, 2016 at 06:13:24AM -0700, Jan Beulich wrote:
[...]
> > --- a/tools/tests/x86_emulator/x86_emulate.h
> > +++ b/tools/tests/x86_emulator/x86_emulate.h
> > @@ -37,3 +37,22 @@
> >  bool emul_test_make_stack_executable(void);
> >  
> >  #include "x86_emulate/x86_emulate.h"
> > +
> > +#define cpu_has_xsave ({      \
> > +    unsigned int eax = 1, ecx = 0; \
> > +    emul_test_cpuid(&eax, &eax, &ecx, &eax, NULL); \
> > +    /* Intentionally checking OSXSAVE here. */ \
> > +    (ecx & (1U << 27)) != 0; \
> > +})
> 
> ... add it here - why? If you mean to put it here, perhaps all of the
> cpu_has_* should be moved?
> 

Yes, I think moving all of them would be better.

Wei.

> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel