Re: [Xen-devel] [PATCH] Fix errornous negation for isstubdom, which breaks HVM pci-passthrough.

[Cedric Bosdonnat <cbosdonnat@xxxxxxxx>]

Nice catch!
ACK from me, thought I don't know if it really counts ;)

--
Cedric

On Sat, 2016-12-10 at 18:59 +0100, Sander Eikelenboom wrote:
> Commit 20b75251d9721d9c050a973c02baac396c794ade introduced an errornous
> negation which gave the isstubdom bool the opposite semantics,
> causing the subsequent code to take the wrong code path.
> 
> Signed-off-by: Sander Eikelenboom <linux@xxxxxxxxxxxxxx>
> ---
>  tools/libxl/libxl_pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
> index 3b707f3..8395352 100644
> --- a/tools/libxl/libxl_pci.c
> +++ b/tools/libxl/libxl_pci.c
> @@ -1001,7 +1001,7 @@ static int do_pci_add(libxl__gc *gc, uint32_t domid, 
> libxl_device_pci *pcidev, i
>      int irq, i, rc, hvm = 0;
>      uint32_t flag = XEN_DOMCTL_DEV_RDM_RELAXED;
>      uint32_t domainid = domid;
> -    bool isstubdom = !libxl_is_stubdom(ctx, domid, &domainid);
> +    bool isstubdom = libxl_is_stubdom(ctx, domid, &domainid);
>  
>      if (type == LIBXL_DOMAIN_TYPE_INVALID)
>          return ERROR_FAIL;

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel