Re: [Xen-devel] [RFC XEN PATCH 02/16] x86_64/mm: explicitly specify the location to place the M2P table

[Haozhong Zhang <haozhong.zhang@xxxxxxxxx>]

On 12/12/16 01:26 -0700, Jan Beulich wrote:
> > > > On 12.12.16 at 03:31, <haozhong.zhang@xxxxxxxxx> wrote:
> > On 12/09/16 16:38 -0500, Konrad Rzeszutek Wilk wrote:
> > > On Mon, Oct 10, 2016 at 08:32:21AM +0800, Haozhong Zhang wrote:
> > > > @@ -1427,7 +1429,7 @@ int memory_add(unsigned long spfn, unsigned long epfn, 
> > > > unsigned int pxm)
> > > >      total_pages += epfn - spfn;
> > > >
> > > >      set_pdx_range(spfn, epfn);
> > > > -    ret = setup_m2p_table(&info);
> > > > +    ret = setup_m2p_table(&info, &info);
> > > I am not sure I follow this logic. You are passing the same contents, it
> > > is just that 'alloc_info' and 'info' are aliased together?
> > Similarly to patch 1, the two parameters of setup_m2p_table() are
> > identical for the ordinary RAM, and can be different for NVDIMM.
> And the same comments as for patch 1 apply here then.
>
> Jan
I'll add comments and clarify in commit messages for both patch 1 and
patch 2 in the next version.

Thanks,
Haozhong

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel