Re: [Xen-devel] [PATCH] x86/hvm: don't create a default ioreq server...

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 12 December 2016 07:54
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH] x86/hvm: don't create a default ioreq server...
> 
> >>> On 09.12.16 at 18:55, <paul.durrant@xxxxxxxxxx> wrote:
> > ...if the domain is not under construction.
> 
> I think the title will end up misleading this way. How about "x86/hvm:
> don't unconditionally create a default ioreq server" with "Avoid doing
> so if the domain is not under construction" as the 1st sentence?
> 

Yes, that would avoid the shortlog being misleading.

> As the patch is otherwise ready to go in, that adjustment could
> certainly be done while committing (i.e. no re-send necessary).
> 

Thanks. I also realised there is typo in the code comment:

" the query should have that side-effect" should be " the query should *not* 
have that side-effect"

Please can you fix this too.

Cheers,

  Paul

> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel