Re: [Xen-devel] [PATCH v3 5/7] tools/fuzz: introduce x86 instruction emulator target

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Dec 12, 2016 at 04:30:30AM -0700, Jan Beulich wrote:
> >>> On 12.12.16 at 12:19, <wei.liu2@xxxxxxxxxx> wrote:
> > On Mon, Dec 12, 2016 at 02:58:39AM -0700, Jan Beulich wrote:
> >> >>> On 12.12.16 at 10:28, <wei.liu2@xxxxxxxxxx> wrote:
> >> > +    /* Reset all global states */
> >> 
> >> DYM "state"?
> > 
> > I mean "states". There are three states we need to reset.
> 
> Hmm, to me as a non-native speaker it feels wrong to use plural
> here (just like for e.g. milk), but maybe I'm wrong.
> 

"State" is countable when used to represent the condition of
somebody/something.  Various other meanings of "state" don't apply here.

Sources:

https://www.oxfordlearnersdictionaries.com/definition/english/state_1
http://www.ldoceonline.com/dictionary/state

> > From: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Date: Thu, 8 Dec 2016 12:09:54 +0000
> > Subject: [PATCH] tools/fuzz: introduce x86 instruction emulator target
> > 
> > Instruction emulator fuzzing code is from code previous written by
> > Andrew and George. Adapt it to llvm fuzzer and hook up the build system.
> > 
> > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxx>
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> > Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Cc: Jan Beulich <jbeulich@xxxxxxxx>
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > Cc: Tim Deegan <tim@xxxxxxx>
> > Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> > 
> > v4:
> > 1. more coding style fixes and bug fixes
> > 2. only do 64 bit build
> 
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> 

Thanks.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel