Re: [Xen-devel] [PATCH 3/5] x86/paging: Enforce PG_external == PG_translate == PG_refcounts

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 12/12/16 11:43, Tim Deegan wrote:
> At 10:43 +0000 on 12 Dec (1481539423), Andrew Cooper wrote:
>> Setting PG_refcounts but not PG_translate is not useful.
>>
>> While adjusting this, make a few other improvements.
>>
>>  * Have paging_enable() unilaterally reject any unknown modes.
>>  * Correct the function description.  paging_enable() is also used to enable
>>    logdirty during runtime.
> Don't run-time log-dirty changes go through paging_log_dirty_{en,dis}able()?

You are completely right.  Sorry for that.  I failed to observe that
logdirty gets pulled out before XEN_DOMCTL_SHADOW_OP_ENABLE is
propagated into shadow_domctl()

I will drop the comment adjustments.

>
> Apart from that, Acked-by: Tim Deegan <tim@xxxxxxx>.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel