Re: [Xen-devel] [PATCH v2] libxl: QED disks support

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Dec 08, 2016 at 02:52:50PM +0100, Cédric Bosdonnat wrote:
> Qdisk supports qcow and qcow2, extend it to also support qed disk
> format.
> 
> Signed-off-by: Cédric Bosdonnat <cbosdonnat@xxxxxxxx>
> ---
>  v2:
>    * Add qed to the list for possible format values in 
> xl-disk-configuration.txt
>    * Add LIBXL_HAVE_QED
> 
> ---
>  docs/misc/xl-disk-configuration.txt |    4 +-
>  tools/libxl/libxl.h                 |    7 +
>  tools/libxl/libxl_device.c          |    1 +
>  tools/libxl/libxl_dm.c              |    1 +
>  tools/libxl/libxl_types.idl         |    1 +
>  tools/libxl/libxl_utils.c           |    2 +
>  tools/libxl/libxlu_disk_l.c         | 1018 
> ++++++++++++++++++-----------------
>  tools/libxl/libxlu_disk_l.h         |   53 +-
>  tools/libxl/libxlu_disk_l.l         |    3 +-
>  9 files changed, 548 insertions(+), 542 deletions(-)
> 
> diff --git a/docs/misc/xl-disk-configuration.txt 
> b/docs/misc/xl-disk-configuration.txt
> index b3402bc33a..310d2586c0 100644
> --- a/docs/misc/xl-disk-configuration.txt
> +++ b/docs/misc/xl-disk-configuration.txt
> @@ -87,7 +87,7 @@ format
>  ------
>  
>  Description:           Specifies the format of image file.
> -Supported values:      raw, qcow, qcow2, vhd
> +Supported values:      raw, qcow, qcow2, vhd, qed
>  Deprecated values:     None
>  Default value:         raw
>  
> @@ -311,7 +311,7 @@ are found prepended to the format parameter - eg 
> "tap:aio:qcow:".
>  ---------
>  
>  Description:           Specifies the format (deprecated)
> -Supported values:      raw:  qcow2:  vhd:
> +Supported values:      raw:  qcow2:  vhd:  qed:

Sorry for not having noticed this earlier: we shouldn't extend the
deprecated syntax here.

I presume there is change to .l file to support this, please remove it.

Other than the issue mentioned above, this patch looks good to me.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel