Re: [Xen-devel] [PATCH v2 LIVEPATCH-BUILD-TOOLS] Fix patch creation with GCC 6.1+

[Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>]

On 12/12/2016 03:01 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, Dec 12, 2016 at 02:55:51PM +0000, Ross Lagerwall wrote:
> > GCC 6.1+ fixed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=192 which
> > means that .rodata.str1.[0-9]+ sections are now split by function.  We
> > could probably be smarter about including just the sections we need, but
> > for now, simply include the string sections for all functions as is done
> > for previous versions of GCC.
> Are there plans to push this to the upstream kpatch repo? Or did
> they do it in some other way?
There isn't an upstream change for this. I _think_ the reason is that 
differences in the way that the Linux kernel is built (e.g. without 
-fPIC), and the way that the kpatch module is created means that kpatch 
is not affected by this.
> > Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> > Reported-by: M A Young <m.a.young@xxxxxxxxxxxx>
> > ---
> >
> > Changed in v2:
> > * Clarified commit message.
> Thanks. Two little nitpicks - feel free to either ignore them
> or take them into account.
>
> Either way:
>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Pushed with the suggested changes. Thanks.

--
Ross Lagerwall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel