Re: [Xen-devel] [PATCH 4/8] libelf: loop safety: Call elf_iter_ok_counted at every *mem*_unsafe

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.12.16 at 16:54, <ian.jackson@xxxxxxxxxxxxx> wrote:
> Jan Beulich writes ("Re: [PATCH 4/8] libelf: loop safety: Call 
> elf_iter_ok_counted at every *mem*_unsafe"):
>> On 09.12.16 at 16:44, <ian.jackson@xxxxxxxxxxxxx> wrote:
>> > -    if ( elf_access_ok(elf, dst, size) )
>> > +    if ( elf_access_ok(elf, dst, size) &&
>> > +         elf_iter_ok_counted(elf, size))
>> 
>> With the style issue here fixed,
>> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>> despite not being really happy about the added clutter.
> 
> I have added the missing space, and also moved the && to the next
> line (as seems to be done in much of the hypervisor).
> 
> I hope that meets with your approval.

Well, I don't mind either placement of the && (personally I like it
better at the front of a line, but the common model in fact is to
have it at the end).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel