Re: [Xen-devel] [PATCH 1/2] x86/hvm: Fix HVMOP_get_param when skipping creating the default ioreq server

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.12.16 at 19:29, <andrew.cooper3@xxxxxxxxxx> wrote:
> c/s e7dabe5 "x86/hvm: don't unconditionally create a default ioreq server"
> added a break statement, but the logic previously depended on falling through
> into the default case to fill in the value the caller asked for.
> 
> This causes the sending migration code to put a junk PARAM into the stream,
> and the receiving side to fail to zero the IOREQ pages, causing QEMU to object
> when it finds stale requests while starting up.
> 
> Reorder the code so it more clearly falls through into the default case.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel