Re: [Xen-devel] [xen-unstable test] 103162: regressions - FAIL

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Dec 13, 2016 at 12:35:13PM +0100, Juergen Gross wrote:
> On 13/12/16 11:43, Wei Liu wrote:
> > On Tue, Dec 13, 2016 at 01:37:46AM -0700, Jan Beulich wrote:
> >>>>> On 12.12.16 at 20:18, <osstest-admin@xxxxxxxxxxxxxx> wrote:
> >>> flight 103162 xen-unstable real [real]
> >>> http://logs.test-lab.xenproject.org/osstest/logs/103162/ 
> >>>
> >>> Regressions :-(
> >>>
> >>> Tests which did not succeed and are blocking,
> >>> including tests which could not be run:
> >>>  build-i386-xsm                5 xen-build                fail REGR. vs. 
> >>> 102942
> >>
> >> While this may be spurious, I'm not sure it's not also indicative of
> >> a build race: At the time of the failure there are three "make[2]"-s
> >> in the process of building inside xen/extras/mini-os-remote/. In
> >> particular I wonder whether
> >>
> >> /home/osstest/build.103162.build-i386-xsm/xen/stubdom/mini-os-x86_32-xenstore/mini-os.o:
> >>  In function `gnttab_alloc_and_grant':
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/gnttab.c:155:
> >>  undefined reference to `_text'
> >> /home/osstest/build.103162.build-i386-xsm/xen/stubdom/mini-os-x86_32-xenstore/mini-os.o:
> >>  In function `call_main':
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/main.c:160:
> >>  undefined reference to `__CTOR_LIST__'
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/main.c:160:
> >>  undefined reference to `__CTOR_LIST__'
> >> /home/osstest/build.103162.build-i386-xsm/xen/stubdom/mini-os-x86_32-xenstore/mini-os.o:
> >>  In function `_exit':
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/main.c:171:
> >>  undefined reference to `__DTOR_LIST__'
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/main.c:171:
> >>  undefined reference to `__DTOR_LIST__'
> >> /home/osstest/build.103162.build-i386-xsm/xen/stubdom/mini-os-x86_32-xenstore/mini-os.o:
> >>  In function `alloc_pages':
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/mm.c:273:
> >>  undefined reference to `_text'
> >> /home/osstest/build.103162.build-i386-xsm/xen/stubdom/mini-os-x86_32-xenstore/mini-os.o:
> >>  In function `free_pages':
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/mm.c:291:
> >>  undefined reference to `_text'
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/mm.c:304:
> >>  undefined reference to `_text'
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/mm.c:314:
> >>  undefined reference to `_text'
> >> /home/osstest/build.103162.build-i386-xsm/xen/stubdom/mini-os-x86_32-xenstore/mini-os.o:
> >>  In function `init_page_allocator':
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/mm.c:157:
> >>  undefined reference to `_text'
> >> /home/osstest/build.103162.build-i386-xsm/xen/stubdom/mini-os-x86_32-xenstore/mini-os.o:/home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/mm.c:157:
> >>  more undefined references to `_text' follow
> >> /home/osstest/build.103162.build-i386-xsm/xen/stubdom/mini-os-x86_32-xenstore/mini-os.o:
> >>  In function `arch_init_mm':
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/arch/x86/mm.c:858:
> >>  undefined reference to `_etext'
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/arch/x86/mm.c:859:
> >>  undefined reference to `_erodata'
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/arch/x86/mm.c:860:
> >>  undefined reference to `_edata'
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/arch/x86/mm.c:862:
> >>  undefined reference to `_end'
> >> /home/osstest/build.103162.build-i386-xsm/xen/stubdom/mini-os-x86_32-xenstore/mini-os.o:
> >>  In function `build_pagetable':
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/arch/x86/mm.c:288:
> >>  undefined reference to `_text'
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/arch/x86/mm.c:294:
> >>  undefined reference to `_text'
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/arch/x86/mm.c:305:
> >>  undefined reference to `_text'
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/arch/x86/mm.c:306:
> >>  undefined reference to `_text'
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/arch/x86/mm.c:314:
> >>  undefined reference to `_text'
> >> /home/osstest/build.103162.build-i386-xsm/xen/stubdom/mini-os-x86_32-xenstore/mini-os.o:/home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/arch/x86/mm.c:333:
> >>  more undefined references to `_text' follow
> >> /home/osstest/build.103162.build-i386-xsm/xen/stubdom/mini-os-x86_32-xenstore/mini-os.o:
> >>  In function `set_readonly':
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/arch/x86/mm.c:397:
> >>  undefined reference to `_erodata'
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/arch/x86/mm.c:397:
> >>  undefined reference to `_text'
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/arch/x86/mm.c:413:
> >>  undefined reference to `_text'
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/arch/x86/mm.c:419:
> >>  undefined reference to `_text'
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/arch/x86/mm.c:441:
> >>  undefined reference to `_erodata'
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/arch/x86/mm.c:399:
> >>  undefined reference to `_erodata'
> >> /home/osstest/build.103162.build-i386-xsm/xen/stubdom/mini-os-x86_32-xenstore/mini-os.o:
> >>  In function `page_walk':
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/arch/x86/traps.c:110:
> >>  undefined reference to `_text'
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/arch/x86/traps.c:113:
> >>  undefined reference to `_text'
> >> /home/osstest/build.103162.build-i386-xsm/xen/stubdom/mini-os-x86_32-xenstore/mini-os.o:
> >>  In function `handle_cow':
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/arch/x86/traps.c:139:
> >>  undefined reference to `_text'
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/arch/x86/traps.c:146:
> >>  undefined reference to `_text'
> >> /home/osstest/build.103162.build-i386-xsm/xen/extras/mini-os-remote/arch/x86/traps.c:157:
> >>  undefined reference to `_text'
> >>
> >> perhaps indicates that the three buildings of
> >> arch/x86/minios-x86_32.lds overlapped in a way resulting in a
> >> corrupt file.
> >>
> > 
> > It seems that there is a race somewhere.
> 
> I'd guess Wei's patch (commit 5623e2d22833b401a731bd717f80fb2ffc5c8b73)
> is to blame: it doesn't honor $(OBJ_DIR) when creating
> arch/x86/minios-x86_32.lds
> 

Yes, that's rather likely. Thanks for looking into this.

> This is the reason a race is possible. Please note: the 3 concurrent
> make invocations all have a different $(OBJ_DIR) specified and hence
> _should_ be save to run in parallel.
> 

I will prepare a patch this afternoon.

Wei.

> 
> Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel